From 070a5ecace9942490cd777e3c1decd1b846a877f Mon Sep 17 00:00:00 2001 From: Leo Goetz Date: Thu, 21 May 2026 08:34:34 +0200 Subject: refactor: removed new promise anti pattern from getAuditPromise --- src/actions/checkDependencies.ts | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) (limited to 'src/actions/checkDependencies.ts') diff --git a/src/actions/checkDependencies.ts b/src/actions/checkDependencies.ts index c248903..4234bf9 100644 --- a/src/actions/checkDependencies.ts +++ b/src/actions/checkDependencies.ts @@ -44,22 +44,21 @@ async function getAuditPromise( dirname: string, spinner: Ora, ): Promise { - return new Promise(async (resolve, reject) => { - await pullLatest(path, spinner); + await pullLatest(path, spinner); - spinner.text = "getting audit"; + spinner.text = "getting audit"; - let { stdout } = await promiseExec(`cd "${path}" && npm audit --json`); + let { stdout } = await promiseExec(`cd "${path}" && npm audit --json`); - let output = JSON.parse(stdout); - let project: Project = { projectName: dirname, ...output }; - if (project.error) { - reject( - `${dirname} could not be audited, maybe package lock is corrupted`, - ); - } - resolve(project); - }); + let output = JSON.parse(stdout); + let project: Project = { projectName: dirname, ...output }; + if (project.error) { + throw new Error( + `${dirname} could not be audited, maybe package lock is corrupted`, + ); + } + + return project; } async function pullLatest(path: string, spinner: Ora) { -- cgit v1.3.1